Skip to content

[server] FetchLogRequest support params: minFetchBytes and maxWaitMs to avoid frequently FetchLogRequest send to server#233

Merged
wuchong merged 3 commits into
apache:mainfrom
swuferhong:fetch-log-min-size
Jan 5, 2025
Merged

[server] FetchLogRequest support params: minFetchBytes and maxWaitMs to avoid frequently FetchLogRequest send to server#233
wuchong merged 3 commits into
apache:mainfrom
swuferhong:fetch-log-min-size

Conversation

@swuferhong

Copy link
Copy Markdown
Contributor

Purpose

Linked issue: #199

This pr is aims to deal with the problem mention in #199 (Client/Follower fetch a empty table, the response will be returned quickly, and immediately, it'll send fetch request again and again)

Tests

API and Format

Documentation

Comment thread fluss-server/src/main/java/com/alibaba/fluss/server/log/LogOffsetSnapshot.java Outdated
Comment thread fluss-common/src/main/java/com/alibaba/fluss/metrics/MetricNames.java Outdated
Comment thread fluss-server/src/main/java/com/alibaba/fluss/server/replica/ReplicaManager.java Outdated
Comment thread fluss-server/src/main/java/com/alibaba/fluss/server/replica/ReplicaManager.java Outdated
Comment thread fluss-common/src/main/java/com/alibaba/fluss/config/ConfigOptions.java Outdated
@swuferhong swuferhong force-pushed the fetch-log-min-size branch 3 times, most recently from a9bb612 to ec71d91 Compare December 30, 2024 06:42
@swuferhong

Copy link
Copy Markdown
Contributor Author

@wuchong comments addressed.

@swuferhong

Copy link
Copy Markdown
Contributor Author

@wuchong conflict resolved, pr ready.

@wuchong wuchong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a commit to improve the config option keys.

@wuchong

wuchong commented Jan 5, 2025

Copy link
Copy Markdown
Member

CI is passed, Merging...

Please check the commit afterward @swuferhong

@wuchong wuchong merged commit 37b7903 into apache:main Jan 5, 2025
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
…pache#233)

This can reduce a lot of frequent FetchLogRequest when the traffic of a topic is very low.

This closes apache#199
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
…pache#233)

This can reduce a lot of frequent FetchLogRequest when the traffic of a topic is very low.

This closes apache#199
fresh-borzoni pushed a commit to fresh-borzoni/fluss that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Server need backoff fetch when fetch empty record to avoid send fetch records again and again

2 participants